collective / icalendar / 32804675268

98%

push

github

Add uid, summary, description, attendees to AlarmTime (#1421) (#1721)

* Add uid, summary, description, attendees getters to AlarmTime

Adds pass-through properties on AlarmTime that delegate to the
underlying Alarm component, following the existing pattern used by
the action property. Part of #1421.

AI: Used Claude(Sonnet 5) to understand the codebase and the relationship
between Alarm and AlarmTime. Property selection (what to include
vs. exclude in AlarmTime) and all code is mine.

* Add completeness test for AlarmTime properties

Adds a test that fails with a clear message if a new lowercase
property is added to Alarm without either a matching pass-through
getter on AlarmTime, or a reasoned entry in
INTENTIONALLY_EXCLUDED_ALARM_PROPERTIES. Also adds the exclusion
list itself, documenting why repeat, triggers, created,
last_modified, stamp, comments, concepts, links, refids, and
related_to are intentionally not mirrored onto AlarmTime (they
describe generic component/lifecycle metadata, cross-references, or
the alarm's overall schedule, not its identity, notification
content, or recipients).

Part of #1421.

AI: Used Claude(Sonnet 5) to work through which Alarm properties
belong on AlarmTime -- it asked guiding questions and pushed back on
inconsistencies in my reasoning, and gave feedback on wording. I
made the actual property include/exclude decisions, wrote and
debugged the code myself.

* Add mock tests for AlarmTime uid, summary, description, attendees

Each test creates a bare Alarm, sets the property directly on it,
wraps it in an AlarmTime, and asserts the value is exposed
correctly. This verifies the getters actually delegate to the
right underlying Alarm property, which the completeness test alone
does not check (it only verifies a property exists, not that it
returns the correct value).

Part of #1421.

AI: Used Claude(Sonnet 5) to identify the existing test pattern to
follow and debug why UID/SUMMARY set via the uppercase raw field
wer... (continued)

1643 of 1782 branches covered (92.2%)

Branch coverage included in aggregate %.

45 of 45 new or added lines in 2 files covered. (100.0%)

14398 of 14669 relevant lines covered (98.15%)

6.87 hits per line