archetech / archon / 32796830887

87%

push

github

refactor(clients): Share one KeymasterUI instead of two identical copies (#940)

* refactor(clients): Share one KeymasterUI instead of two identical copies

Step 1 of #99. The demo UI existed as two byte-identical copies, 8812
lines each, that had to be edited in lockstep -- #919 needed patching in
both, and #936 applied every edit twice with a byte-identity check to stay
honest. It now lives once in packages/keymaster-ui, aliased by both
clients, taking this UI from three source trees to two.

Not the wallet-ui consolidation, deliberately. Those are architecturally
opposite: KeymasterUI uses zero React contexts and takes keymaster as a
prop with ~100 useState hooks in one component, while 22 of wallet-ui's 36
components consume its contexts. Unifying them is a rewrite, not a move,
and worth deciding on its own.

Two things about the bundles, both chased rather than waved past.

The first build grew 25%, 845,696 -> 1,057,320. Consuming a package as
source means its bare imports resolve upward to the copies npm installs at
the root for its peerDependencies, so React and MUI loaded twice. Neither
client had a dedupe list, having never consumed source before. Same hazard
#930 hit with wallet-ui.

With dedupe it came out SMALLER than baseline, 790,842, which needed
explaining rather than accepting. Removing just the axios entry gives
848,971 -- so the move itself costs ~3KB for the re-export layer, and the
other 55KB was a duplicate axios that predates this change. An incidental
fix.

Two existing guards caught the move without being asked: tsc flagged the
stale import (#923), and tests/wallet/oob-codec.test.ts failed to resolve
it. That test asserted the two copies were byte-identical, which is now
true by construction; it asserts instead that no app-local copy comes back,
which is what the original was really protecting. AGENTS.md carried the
same lockstep rule and now says where the file lives.

2270 tests, eslint silent, typecheck 0, both clients buil... (continued)

3854 of 4341 branches covered (88.78%)

Branch coverage included in aggregate %.

8484 of 8794 relevant lines covered (96.47%)

690.73 hits per line