NVIDIA / gpu-operator / 32787066964
44%
main: 45%

LAST BUILD BRANCH: pull-request/3103
DEFAULT BRANCH: main
Ran
Jobs 1
Files 73
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 37.688%. Remained the same
32787066964

push

github

abrarshivani 
fix(ci): stop reading a failed query as a satisfied condition

Now that the tests drive the cluster from the runner, a kubectl call can fail
at any point, and several checks turned that failure into a value that happens
to satisfy what they were waiting for. Counting through a pipe reports zero
when kubectl writes nothing, so a deletion check saw the resource as gone and
an ownership check saw every node as owned. Iterating over a command
substitution runs the body no times, so the label check in
test_custom_labels_override could report success without reading a single
label. Testing a bare kubectl for non-zero treats unreachable the same as
NotFound.

Ask whether the query succeeded before reading what it said. A query that
failed reports through api_unreachable and falls through to the retry, and the
loops still stop on their existing deadlines. Deletion checks use -o name with
--ignore-not-found so an absent object is a successful query returning
nothing, which is a real answer, rather than an error.

Comparisons against a node count also require the count to be above zero. This
environment always has a GPU node, so zero means the count never arrived, and
without that guard a zero on both sides of the comparison reads as done.

The one-shot assertions fail when their query fails rather than retrying,
since there is no loop around them and a check that could not run has not
passed.

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>

4881 of 12951 relevant lines covered (37.69%)

0.38 hits per line

Jobs
ID Job ID Ran Files Coverage
1 32787066964.1 73
37.69
GitHub Action Run
Source Files on build 32787066964