jzombie / term-wm / 32782721526

86%

Build Type

push

github

Committed by web-flow

Commit Message

fix(workspace): CI test flakiness (#317)

* fix(workspace): CI test flakiness

Added

- **Configurable log path (`TERM_WM_LOG_FILE`, #270):** tracing events
  can now tee to a durable file instead of living only in the in-memory
  Debug Log ring buffer (lost on exit). In the `term-wm` binary every
  event that reaches the Debug Log window also appends to the configured
  file; framework noise redirected at the OS level flows there too. The
  `term-session` daemon gains a matching subscriber: detached daemons
  null their stdio by design (an undrained pipe would deadlock startup),
  so until now their diagnostics were unrecoverable on any failure; with
  `TERM_WM_LOG_FILE` set they write full tracing output (honoring
  `RUST_LOG`) to the file instead of discarding it. The root binary's
  standalone `--daemon` mode, which previously had no subscriber at all,
  now initializes logging as well. Opening the file is best-effort:
  failures fall back to existing behavior with a warning.
- **Shared deterministic test utilities (`term-test-support`, #309):** a
  new dev-only workspace crate consolidates the patterns every suite was
  hand-rolling: `wait_for`/`wait_for_async` deadline-bounded condition
  polling, `KillOnDrop` RAII cleanup guards (fire exactly once,
  including during panic unwinding), a thread-safe `ManualClock` virtual
  clock for timer tests, `unique_gateway_name` (pid + counter IPC
  names), and `apply_test_logging`, which points spawned test processes
  at `TERM_WM_LOG_FILE` under a stable per-run directory
  (`TERM_WM_TEST_LOG_DIR`, default `<temp>/term-wm-test-logs/`) so CI
  can archive daemon diagnostics from failed runs.

Fixed

- **Recurring CI test flakiness eliminated at the roots (#309):** no
  retry layer was added; every known flake class got a deterministic
  fix. Blind fixed sleeps in the daemon/session suites (a 2 s wait for
  the whole auto-spawn chain in `daemon_survives_parent_death`, a 1 s
  teardown hope, a 100 ms gateway... (continued)

Coverage Stats

462 of 509 new or added lines in 19 files covered. (90.77%)

67 existing lines in 4 files now uncovered.

53103 of 61780 relevant lines covered (85.96%)

243758.68 hits per line