• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In
Warning: This build has drifted.
The coverage report for this pull request build may be inaccurate because its base commit is no longer the HEAD of its target branch.
This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

    • Learn more: For more information on this, see Tracking coverage changes for pull request builds.
    • Fix now: For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
    • Prevent going forward: To avoid this issue with future PRs, see these Recommended CI Configurations.
New Repo Setting:
INCLUDE COVERAGE % WITH WARNINGS ABOUT DRIFTED BUILDS?

Enabling this setting will include a (potentially inaccurate) coverage % with warning messages in status updates for drifted builds.

Adjust setting

kubeflow / trainer / 32743098422
69%
master: 81%

Build:
Build:
LAST BUILD BRANCH: improve-coderabbit
DEFAULT BRANCH: master
Ran 24 Aug 2026 03:15PM UTC
Jobs 1
Files 43
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

24 Aug 2026 03:08PM UTC coverage: 68.5% (-0.1%) from 68.626%
32743098422

Pull #3918

github

Abhishek86798
fix(manifests): grant the controller read access to priorityclasses

The Volcano plugin validates spec.priorityClassName by doing a client.Get
on the named PriorityClass, but the controller ClusterRole never granted
any access to scheduling.k8s.io/priorityclasses.

Because the plugin uses the cached controller-runtime client, the missing
permission makes the PriorityClass informer fail to list, so the cache
never syncs and the Get blocks until the webhook times out. Creating a
TrainJob whose runtime sets a priorityClassName then fails with an
InternalError instead of being admitted:

  Internal error occurred: failed calling webhook
  "validator.trainjob.trainer.kubeflow.org": context deadline exceeded

This affects any user-defined priority class today, and after the reserved
system names stopped being skipped it affects those as well.

Add the kubebuilder RBAC marker on the Volcano plugin, regenerate
manifests/base/rbac/role.yaml, and mirror the rule in the Helm chart
ClusterRole.

Verified on a KinD cluster with Volcano installed: TrainJobs using
system-cluster-critical, system-node-critical and a user-defined
PriorityClass are all admitted and run to completion under the volcano
scheduler, while an unknown name is still rejected by the webhook.

Signed-off-by: Abhishek <abhikokadwar2@gmail.com>
Pull Request #3918: fix(framework): validate all ReplicatedJobs in Volcano priorityClassName check

2 of 2 new or added lines in 1 file covered. (100.0%)

54 existing lines in 3 files now uncovered.

2603 of 3800 relevant lines covered (68.5%)

0.8 hits per line

Coverage Regressions

Lines Coverage ∆ File
30
30.65
30.65% pkg/statusserver/setup.go
14
50.31
9.18% pkg/statusserver/server.go
10
28.85
-0.57% pkg/util/cert/cert.go
Jobs
ID Job ID Ran Files Coverage
1 32743098422.1 24 Aug 2026 03:15PM UTC 43
68.5
GitHub Action Run
Source Files on build 32743098422
  • Tree
  • List 43
  • Changed 5
  • Source Changed 0
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #3918
  • PR Base - master (#31531954434)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc