geosolutions-it / MapStore2 / 32731619481

76%

Build Type

push

github

Committed by web-flow

Commit Message

Template resolution and link handling (#12824)

* refactor: resolve template placeholders without compiling them

Templates are resolved with generateTemplateString, that now keeps 0 and false
instead of replacing every falsy value. Only property references are supported,
expressions are not.

* refactor: move link target checks to URLUtils

getSafeHref keeps the references without protocol and drops the others,
isValidURL rejects non strings and paths resolved on another host.

* fix: report permalink targets that are not application paths

* chore: use getSafeHref for geostory and catalog links

* test: coverage for the html rendering components

Coverage Stats

36921 of 57825 branches covered (63.85%)

40 of 45 new or added lines in 9 files covered. (88.89%)

12 existing lines in 5 files now uncovered.

45784 of 60274 relevant lines covered (75.96%)

126.24 hits per line