zentralopensource / zentral / 32724645246

91%

push

github

osquery: paginate the API list endpoints

The seven list endpoints of the Osquery module answered with the whole table. A
list of every query or every pack grew with the fleet, and nothing bounded the
response.

They answer with a page now, through MaxLimitOffsetPagination: 50 objects by
default, 500 at most. Each queryset also gets a total ordering, which pagination
needs. An ordering on a column that is not unique lets a row move between two
pages, and the client then reads it twice or not at all. The five orderings on
"name" are total because the name is unique on those models, and the enrollments
and the configuration packs, which have no name, are ordered on the primary key.

The orderings are the ones of #1628, so that the Osquery part of that pull
request is a deletion and not a merge. The assertions of the list tests come from
it as well.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

14 of 14 new or added lines in 1 file covered. (100.0%)

51197 of 56855 relevant lines covered (90.05%)

0.9 hits per line