wirenboard / wb-device-manager / 7

56%

main: 56%

Build Type

Pull #85

github

Committed by KraPete

Commit Message

Remove firmware update leftovers from serial code

Nothing has reached the Modbus write path since firmware update moved to
wb-mqtt-serial.

serial_rpc: drop SerialRPCWrapper.write and set_poll, value_to_bytes,
ParameterConfig.write_fn, the data argument of _send_request_to_port,
StepParameterConfig with WB_DEVICE_STEP_PARAMETERS and
get_parameter_with_step, SerialConfig.set_default_settings and both
register-value converters. WB_DEVICE_PARAMETERS keeps the three entries
the bootloader scan reads.

serial_device: drop Device.write, Device.set_poll, check_updatable,
set_default_port_settings and create_device_from_json.

state_error: drop the error classes nothing instantiates any more. The
ids stay documented: they arrive from wb-mqtt-serial as raw dicts (see
StateError(**error) in the scanners), which is also why read_sn_error
never had a class of its own.

ModbusFunctionCode is kept whole - it is a Modbus constant table, not
dead code.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Pull Request Pull Request #85: Proxy fw-update RPCs to wb-mqtt-serial

Coverage Stats

114 of 115 new or added lines in 6 files covered. (99.13%)

15 existing lines in 4 files now uncovered.

663 of 1177 relevant lines covered (56.33%)

1.13 hits per line