SwissDataScienceCenter / renku-data-services / 32716362548

86%

Build Type

push

github

Committed by web-flow

Commit Message

feat(BuildStrategy): use flag to activate insecure registries (#1359)

* refactor: move insecure registry configuration behind a proper flag

The Renku admins can now enable/disable the use of insecure
registries through the BUILD_INSECURE_OUTPUT_ENABLED environment
variable.

This flag will be forwarded to Shipwright through the output
parameters.

The BuildStrategy now follows more closely the implementation
from Shipwright and respects that flag.

* fix: correct typo in configuration

Co-authored-by: Tasko Olevski <16360283+olevski@users.noreply.github.com>

* refactor: improve insecure registries handling

- Revert the last changes as setting insecure registries
and handling the output as insecure can be independent
(e.g. pulling dependencies VS pushing the output).

- Add a warning if the registry for the output image is
listed as insecure registries while the insecure output
option is disabled.

- Handle properly empty insecure registry list

* feat: ensure that the private registry is not listed in insecure registries

The fact that the output shall go to an insecure registry
is a separate concern from secure registries providing items
for the build.

* refactor: move back to a simpler approach for insecure registries handling

Some of the checks are now done directly in the configuration of
the feature so no need to make them again in the BuildStrategy.

The back and forth between string and list and then back to
string was not a good idea.

Coverage Stats

8 of 9 new or added lines in 3 files covered. (88.89%)

7 existing lines in 5 files now uncovered.

27807 of 32425 relevant lines covered (85.76%)

1.48 hits per line