FROSADO / onecloudriver / 32695783060

81%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(graph): drop dead DefaultBaseURL trim in PollDelta deltaLink (#125)

* refactor(graph): drop dead DefaultBaseURL trim in PollDelta deltaLink

The TrimPrefix inside the !strings.HasPrefix(deltaLink, "http") guard was
unreachable: DefaultBaseURL starts with "https://", so any string that
begins with it also begins with "http". Return the deltaLink verbatim; the
next poll already resolves and validates it via absoluteURL +
validateFollowURL. Add regression tests for the verbatim return (absolute
and relative) and for following a relative delta link on the next poll.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

* fix(auth): flush OAuth callback page before tearing down the server

The handler signaled errCh/resultCh before the response page reached the
socket; getAuthCodeLocalServer then returned and server.Close() truncated
the in-flight response (browser/test client saw EOF, and the retry loop in
TestGetAuthCodeLocalServer_CallbackOutcomes failed with connection refused
under -race). Write and flush the page before signaling, so the outcome is
delivered to the browser deterministically (issue #126).

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

* fix(auth): use comma-ok form for the Flusher type assertion

errcheck (with check-type-assertions, as in .golangci-security.yml)
rejects the unchecked w.(http.Flusher) assertion. Extract flushCallbackPage
and assert with the comma-ok form, which is also panic-safe for writers
that do not implement Flusher.

🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

---------

Co-authored-by: Codebuff <noreply@codebuff.com>

Coverage Stats

14 of 14 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

5660 of 7014 relevant lines covered (80.7%)

3023.8 hits per line