google / sedpack / 32692910649

89%

push

github

Fix ShardWriter round-trip test: missing assertions and degenerate bool data (#397)

### Description

This test had two bugs that weakened its intended coverage:

* `np.array_equal(...)` was called without checking its return value, so
the read-back comparisons never actually asserted anything. The fix
replaces this with `np.testing.assert_array_equal`, which raises on
mismatch.

* The bool attribute used `np.random.randint(0, 1, ...)`, which always
returns 0 (its upper bound is exclusive), so only all-`False` data was
round-tripped. The fix replaces this with an explicit array containing
both `True` and `False`.

### Testing

* `python -m pytest tests/io/shard/test_shard_writer_flatbuffer.py
tests/io/shard/test_shard_write_and_read.py` - all 14 passed, with four
existing unsigned-cast warnings.

### AI Disclosure

I didn't use AI to write any of this code, but I technically found these
bugs during an AI-assisted static analysis project that I've been
working on. The AI assisting me was OpenAI Codex gpt-5.6-sol (xhigh).
Just stating that for transparency; maintainers, just yell if this
disclosure is too pedantic.

11 of 11 new or added lines in 1 file covered. (100.0%)

3075 of 3470 relevant lines covered (88.62%)

0.89 hits per line