go-pkgz / auth / 32675477149

86%

master: 86%

Pull #318

github

Restore the plumbing test lost in the rebase

Rebasing this branch onto current master hit conflicts in auth_test.go, and I
resolved them by taking master's side, which silently dropped the test that
came with the change. Coveralls caught it: the new field reaches the token
service through a struct literal nothing asserted, and the warning branch for
Partitioned without Secure had no coverage at all.

TestNewService_PassesCookieOptionsToTokenService is the recovered one, and it
exists because that literal has dropped a field twice before, for SameSite and
for XSRFIgnoreMethods, both in diffs shaped exactly like this one.
TestNewService_WarnsOnPartitionedWithoutSecure covers the warning, which is the
only signal a caller gets for a pairing that produces a header browsers discard
without any error.

Both mutation-checked: removing the struct field fails the first and not the
second, removing the warning fails the second and not the first.

46 of 46 new or added lines in 2 files covered. (100.0%)

3236 of 3755 relevant lines covered (86.18%)

9.65 hits per line