fluentassertions / fluentassertions / 32632443644

98%

push

github

Fix potential NREs when using AssertionScope (#3178) (#3323)

* Fix potential NREs when using AssertionScope (#3178)

Several assertion methods evaluated a member of a possibly-null subject as part of the argument to a chained ForCondition call. Outside of an AssertionScope, an earlier failure throws immediately so the chain never reaches this point. But inside an AssertionScope, execution continues, and the eager dereference throws a NullReferenceException instead of producing a proper assertion failure message.

Fixed by using null-conditional comparisons (subject?.Member == expected) instead of eager dereferences, and by making a failure message in TypeAssertions.HaveProperty lazy so it isn't evaluated when the property doesn't exist.

Affected members:
- PropertyInfoAssertions: BeVirtual, NotBeVirtual, BeWritable (both overloads), NotBeWritable, BeReadable (both overloads), NotBeReadable, Return, NotReturn
- TypeAssertions: HaveProperty, HaveIndexer

Added regression tests wrapping the affected assertions in an AssertionScope, and a releases.md entry.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Address review feedback: simplify regression test assertions, clarify release note

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

4155 of 4438 branches covered (93.62%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 2 files covered. (100.0%)

13356 of 13583 relevant lines covered (98.33%)

79642.05 hits per line