MewX / light-novel-library_Wenku8_Android / 32630309008

36%

master: 36%

push

github

Deleting a dead method, and auditing the migration that already exists

Removes onSearchClicked. It was @Deprecated, had no callers anywhere including
tests and api/, and reached straight for searchHistory.size() where every sibling
guards the lazily loaded static with a null check first -- the same defect that
was fixed in moveBookToTheTopOfBookshelf. Full suite of 184 tests passes after.

Audits what storage would need if an old-data migration were ever required, and
records three answers found by reading rather than remembering.

Nothing in the GlobalConfig split needs one: every on-disk format and path
decision was preserved exactly, separators included.

The V0/V1 reading positions are not a versioning case despite the names.
read_saves.wk8 is keyed by cid and holds a scroll offset for the vertical reader;
read_saves_v1.wk8 is keyed by aid and holds line and word indices for the paged
reader and the continue-reading entry. Both are live and neither converts into
the other, so there is nothing to migrate. The // deprecated comment on both
fields is wrong and misleads whoever reads the class next.

The external-to-internal migration passes two of this document's four constraints
and fails two. It never deletes originals and it reports counts. It is not
resumable on partial failure -- markMigrationCompleted() runs unconditionally
after the copy loop even when files failed, and revertMigrationStatus() has no
caller, so there is no way back. And it is barely tested: two tests, both about
the shape of a path string, none touching the plan, the copy or the failure path.

That is latent rather than harmless. A file that failed to copy is still found,
because the migration copies rather than moves and the backup root still points
at external storage -- but that depends on external storage staying readable,
which is exactly what is in doubt on API 33+ and the reason the migration exists.

No format carries a version marker except settings, and nothing read... (continued)

921 of 3240 branches covered (28.43%)

Branch coverage included in aggregate %.

2768 of 7058 relevant lines covered (39.22%)

1.87 hits per line