Tatsh / smlab / 32615524315

100%

Build Type

push

github

Committed by Tatsh

Commit Message

warp: grid the whole song, not only what comes after beat zero

Nothing was drawn before beat zero, so an offset of a few seconds left the intro
with no lines over it at all. That reads as the grid starting late rather than as
there being nothing to draw, and it makes an offset look wrong when it is right.
Beats before zero are now walked out too, numbered downwards from it.

The waveform was also drawn on a slightly different scale from the grid. Every
column was given the same whole number of samples, which drops the remainder, so
a row of audio came out a little narrower than the slot the grid was drawn in and
the two slid apart by about twenty milliseconds by the right edge. That is the
same size as the error the picture exists to show. Columns now cover exactly
their own share of the row, checked against a click track whose beats are known:
lines land within two milliseconds of the clicks they belong to, all the way
across.

The running mean behind the colouring is shorter than what it averages, which
left the last column of the last row with nothing to measure. Its tail is held
instead.

drift now prints where beat zero was put and how far apart the beats are, so an
offset can be checked against a number rather than against pixels.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

Coverage Stats

766 of 796 branches covered (96.23%)

Branch coverage included in aggregate %.

1 of 17 new or added lines in 2 files covered. (5.88%)

2 existing lines in 1 file now uncovered.

3745 of 3823 relevant lines covered (97.96%)

2.94 hits per line