archetech / archon / 32602925874

95%

push

github

test(wallets): Render the provider trees, so a blank page fails a check (#929)

* test(wallets): Render the provider trees, so a blank page fails a check

Closes #914.

Nothing in this repo rendered a React component, so a crash on first
render shipped with every check green -- as it did on #912, where both
wallets showed a blank page and the commit passed tsc in both apps, lint,
the vite build, the webpack build, 84 wallet tests and all 30 checks. A
human opening the app found it.

vitest with jsdom in each app rather than a jsdom project at the root:
apps/* are not workspaces, so react, MUI, emotion and the rest live only
in each app's node_modules and would have to be hoisted to the root purely
for tests -- duplicating React, which is the thing both apps' dedupe lists
exist to prevent. react-wallet's config extends its own vite.config, so
its fifteen aliases and dedupe apply exactly as in a real build.

The important part is which test does the work. Mounting alone stops at
the passphrase modal, because WalletProvider gates children behind isReady
and a wallet with no data is correctly not ready -- and UIProvider, the
provider that threw on #912, lives INSIDE that gate. A mount-only test
never runs the hook that failed: reintroducing the bug against that
version stayed green. So the tests drive real setup, and only then assert
the children render.

Verified by reintroducing the exact #912 change (useOptionalWalletNavigation
-> useWalletNavigation in useWalletData). Both wallets now fail with the
original message; the first two assertions in each file still pass, which
is why the third exists.

Four things the environment needed, each added because something threw:
- jsdom installs its own realm's typed arrays, so a Node Buffer fails
  `instanceof Uint8Array`; bip39 hands one to the HD key derivation and
  @noble/hashes rejects it, surfacing as "Invalid parameter: mnemonic"
  because newWallet catches and relabels it
- matchMedia, which MUI's useMed... (continued)

3805 of 4293 branches covered (88.63%)

Branch coverage included in aggregate %.

8465 of 8776 relevant lines covered (96.46%)

689.51 hits per line