kubernetes-sigs / external-dns / 32596046857
82%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 157
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 82.031% (-0.005%) from 82.036%
32596046857

push

github

web-flow 
fix(source): collect annotation hostnames before FQDN template (#6644)

* fix(source): collect annotation hostnames before FQDN template

Move template evaluation after annotation hostname collection in gateway
route resolution, so the resolution order matches what's documented:
spec hostnames, then annotation, then FQDN template, then listener
fallback. Previously the template ran first, so a configured template
could fire (or a combining template append) before the annotation had a
chance to already name the record.

Also renamed the two collaborating functions for clarity: hosts ->
resolveHostnames (it resolves the final hostname list, not just "the
hosts"), and applyGatewayTemplate -> appendFQDNTemplate (it only
conditionally appends template output, it doesn't unconditionally
"apply" anything).

Signed-off-by: zanarelli <zanarelli.dev@gmail.com>

* fix(source): empty hostname annotation should not block FQDN template

An annotation key present with an empty value (e.g. external-dns.
alpha.kubernetes.io/hostname: "") contributed a one-element slice
containing "" to the hostname list, which made the FQDN template
fallback gate see a non-empty list and skip the template even though
no real hostname had been supplied. Filter out empty values from the
annotation-derived hostnames before they reach the template gate, so
they behave the same as an absent annotation, matching master's
behavior for this case.

Signed-off-by: zanarelli <zanarelli.dev@gmail.com>

* fix(source): shorten verbose code comments per review

Applied mloiseleur's suggested phrasing directly.

---------

Signed-off-by: zanarelli <zanarelli.dev@gmail.com>

17489 of 21320 relevant lines covered (82.03%)

1467.19 hits per line

Coverage Regressions

Lines Coverage ∆ File
33
88.32
 -0.02% gateway.go
1
86.07
 -0.82% openshift_route.go
Jobs
ID Job ID Ran Files Coverage
1 run-ubuntu-latest - 32596046857.1 157
82.03
 GitHub Action Run
2 run-macos-latest - 32596046857.2 157
81.99
 GitHub Action Run
Source Files on build 32596046857