zentralopensource / zentral / 32590711602

91%

push

github

mdm: do not put the error from S3 in the enterprise app API response

The last of the three callers of download_external_resource that sent
everything boto3 raises to the client through str(e). Those messages can carry
the bucket, the key, the region or the state of the credentials.

The package API and the data asset API already answer this way: pass the
ValueError that carries an operator-facing message, log the rest and answer with
a generic one. read_package_info runs in the same try and raises a ValueError
for its own message about the file extension, so that one still reaches the
client.

The test mocked the failure from S3 with a ValueError, which no error from boto3
resembles, and asserted that its message reached the client. It raises a plain
exception now, and checks that the message stays in the log.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

4 of 4 new or added lines in 1 file covered. (100.0%)

51132 of 56792 relevant lines covered (90.03%)

0.9 hits per line