dennisdoomen / packageguard / 32590245670

81%

Build Type

push

github

Committed by web-flow

Commit Message

Migrate remaining raw Path/Directory calls to Pathy's ChainablePath (#235)

Pathy is already a dependency and adopted throughout PackageGuard.Core's
project/config discovery code, but the newer risk-reporting and SBOM
code was still built on raw System.IO.Path/Directory chains -
including some genuinely gnarly directory-vs-file sniffing and
extension-swapping logic in the report path resolvers.

- RiskHtmlReportWriter/RiskSarifReportWriter: replace chained
  Path.Combine/GetFullPath/GetDirectoryName/GetExtension calls with
  ChainablePath's `/` operator, .Directory, .Extension, .IsFile,
  .IsDirectory and .CreateDirectoryRecursively(); the SARIF
  relative-URI computation now uses AsRelativeTo().
- SbomWriter/SbomModelBuilder: simplify output-directory creation and
  root-name resolution.
- NuGetPackageAnalyzer/NuGetPackageSigningRiskEnricher: build the
  nuspec/nupkg cache paths via the `/` operator instead of
  Path.Combine.
- CSharpProjectScanner: drop the one remaining raw Path.GetFullPath
  call in favor of ChainablePath.ToAbsolute().

Also fixes a latent edge case surfaced while migrating
SbomModelBuilder.ResolveRootName: ChainablePath.From throws on an
empty string, unlike the raw Path/File/Directory APIs it replaces, so
an explicit empty-path guard was added to preserve the existing
behavior for SbomWriter.Write(..., projectPath: "", ...).

All public method signatures are unchanged (ChainablePath is used
internally only, converted at the edges via its implicit string
conversions), so no API surface change and no AcceptApiChanges run
needed.

Coverage Stats

1692 of 2426 branches covered (69.74%)

Branch coverage included in aggregate %.

39 of 51 new or added lines in 7 files covered. (76.47%)

1 existing line in 1 file now uncovered.

5299 of 6494 relevant lines covered (81.6%)

1894.36 hits per line