uwolfer / gerrit-rest-java-client / 32584871421

93%

push

github

Bump vendored com.google.gerrit.extensions copies to latest upstream (#297)

Refreshes the vendored Gerrit extension API/model classes under
com/google/gerrit/* to match current upstream Gerrit, and removes the
now-unused com.google.gwtorm package (its only consumer, the old
Changes.java, no longer depends on it upstream).

- Updated existing vendored interfaces/DTOs to their current upstream
  content, restoring this repo's local NotImplemented-stub convention
  for every API interface and re-applying the established pattern of
  commenting out members that pull in server-only plugin SPI
  (webui.TopMenu, webui.UiAction) that this client doesn't vendor.
- Added new upstream interfaces/DTOs needed to keep implementing
  against the bumped API (e.g. FlowApi, CachesApi, ExperimentApi,
  SubmitRequirementApi, ReviewerInput/ReviewerResult, the Flow* and
  SubmitRequirement* models, restapi.Response/BadRequestException),
  including new small dependencies (common.UsedAt,
  common.ConvertibleToProto, annotations.ExtensionPoint,
  auth.AuthTokenInfo/AuthTokenInput) that those files require to
  compile. ChangeIdentifier and ChangeInfoDifference are hand-written
  without @AutoValue to avoid pulling in a new annotation-processor
  build dependency.
- Left untouched the few vendored files that no longer have an
  upstream counterpart but are still exercised by our own client code
  (AddReviewerInput/AddReviewerResult, AssigneeInput, RobotCommentApi,
  RobotCommentInfo, StarsInput), consistent with this repo's existing
  practice for deprecated/removed upstream surface.
- Made the minimal client-code changes forced by real upstream
  signature/field changes so the project keeps compiling and behaving
  correctly: ChangeApi.addReviewer/ChangesRestClient query building,
  RevisionApi.submit's new ChangeInfo return type, removed
  publish()/robotComments()/delete()/submitPreview() methods, renamed
  FileContentInput and LabelDefinitionInput fields, removed
  DiffR... (continued)

225 of 297 branches covered (75.76%)

1481 of 1590 relevant lines covered (93.14%)

5.08 hits per line