uwolfer / gerrit-rest-java-client / 32573123712

93%

push

github

Require JDK 11 to build (#293)

* Require JDK 11 to build

CI (.github/workflows/build.yml) already builds with JDK 11; make that
requirement explicit via maven-enforcer-plugin so a build on an older
JDK fails fast with a clear message instead of a confusing downstream
error. The compiled artifact still targets Java 8 (jdk.min.version), so
downstream consumers of the published jar see no change - only the
build/test toolchain needs JDK 11. Also bump AppVeyor's JAVA_HOME to
JDK 11 to match, since it was still pinned to JDK 8.

This paves the way for bumping testng to its latest release, which
itself requires JDK 11 (follow-up change).

* Discover JDK 11+ dynamically on AppVeyor instead of a hardcoded path

The hardcoded C:\Program Files\Java\jdk11 JAVA_HOME broke the AppVeyor
build (verified against several other Maven projects' appveyor.yml
that this alias is normally present, but it apparently isn't on
whatever base image this project's AppVeyor account currently uses).
Discover whatever JDK 11+ is actually installed under
C:\Program Files\Java instead of guessing a specific alias, so this
doesn't depend on the exact image/JDK-naming convention.

* Install JDK 11 explicitly via Chocolatey on AppVeyor

Both the hardcoded C:\Program Files\Java\jdk11 path and a dynamic
Get-ChildItem discovery under C:\Program Files\Java still failed,
which strongly suggests this AppVeyor project's build image simply
doesn't ship a JDK 11+ at all (only the JDK 8 the original config
used). Stop depending on whatever the image happens to preinstall and
explicitly install a known JDK via `choco install temurin11`, following
the same validated pattern used by other Maven/AppVeyor projects (e.g.
MicroFocus/octane-ci-java-sdk), which installs to
"C:\Program Files\Eclipse Adoptium\jdk-11*".

* Downgrade maven-enforcer-plugin to 3.0.0

The actual AppVeyor failure (visible in its log, which isn't reachable
from this environment) was never about JDK setup: maven-enforcer-plugin
3.... (continued)

225 of 297 branches covered (75.76%)

1484 of 1589 relevant lines covered (93.39%)

5.09 hits per line