uwolfer / gerrit-rest-java-client / 32570187755

93%

push

github

Bump embedded test Jetty from 8.2.0.v20160908 to 9.4.57.v20241219 (#292)

Jetty 8.2.0.v20160908 is a 2016-era release; 9.4.57.v20241219 is the
latest release on the still Java-8-compatible 9.4.x line (Jetty 10+
requires Java 11, Jetty 12 requires Java 17), so no JDK bump is needed
for this dependency. Only test scope is affected.

Update GerritRestClientTest's embedded server setup for the Jetty 9 API:
- HashLoginService.putUser(...) was removed; credentials are now
  registered via a UserStore handed to setUserStore(...).
- Connector no longer exposes getLocalPort(); cast to NetworkConnector.
- ServletContextHandler now auto-registers a default 404 servlet for
  any unmapped path in its context ("ensureDefaultServlet"), which
  swallowed every request under the login servlet's default "/" context
  before it could fall through to the sibling resource/security
  handlers. Disable that on the login context to restore the original
  handler-chain fallthrough.
- ResourceHandler used standalone (no enclosing context) now rejects
  requests where the resolved resource's canonical path differs from
  the requested one as an "alias" - which is exactly what happens for
  a directory requested without its trailing slash (e.g. "/accounts/self"
  used for welcome-file resolution). Wrap it in a ContextHandler with
  ApproveAliases to restore the previous behavior; safe here since it
  only ever serves this test's own static fixture files.

Co-authored-by: Claude <noreply@anthropic.com>

225 of 297 branches covered (75.76%)

1484 of 1589 relevant lines covered (93.39%)

5.09 hits per line