archetech / archon / 32546307982

94%

main: 95%

Pull #921

github

fix(keymaster-service): Serve the DIDComm API from the Python flavor too

The Python service registered none of the DIDComm routes -- `grep -c
didcomm app.py` was 0 -- so all eleven SDK didcomm methods fell through
to the catch-all 404 while working fine against the JS service. The
`keymaster` library has implemented the operations since #633; only this
routing layer was missing, and nothing checked.

Closes #920.

Two neighbours were missing for the same reason, so this closes them at
the same time: GET /capabilities and POST|DELETE /addresses/publish. That
brings the two route surfaces to exact parity in both directions, which
means the new guard needs no allowlist to rot.

The guard compares the JS routers against app.py -- paths, methods, and
public-vs-protected, read from the mount order around createRequireAdminKey
rather than a hardcoded list. It resolves each createXRouter to its file by
looking for the export, not by mangling the name into a filename: the first
draft guessed keymaster-did-comm-router.ts, silently dropped the router it
was written to check, and passed. Mutation-tested by renaming a route.

That guard also found a live bug: POST /polls/ballot/send was declared
after POST /polls/{poll}/send, and FastAPI matches in declaration order, so
a ballot send arrived as send_poll(poll="ballot"). Verified against
unmodified main by resolving the route through the real app. Both it and
the new /addresses/publish now sit ahead of the templates that would
swallow them, with a test for that ordering class.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

3806 of 4293 branches covered (88.66%)

Branch coverage included in aggregate %.

8465 of 8776 relevant lines covered (96.46%)

689.51 hits per line