lsm / HyperNeo / 32542036398

80%

push

github

fix(scripts): wire zero-comments enforcement into make check and make format (#2685)

* fix(scripts): wire zero-comments enforcement into make check and make format

Run check:no-comments first in the check chain (with format:check folded
in) so pre-existing gate failures cannot mask comment violations, strip
comments before biome in make format, and add a strip-comments script
plus make target for one-off stripping.

* test(daemon): move tests into describe blocks matching the function under test

Clears the two pre-existing check:test-quality describe-scope findings so
the full check chain can pass: the parsePositiveInt test moves out of
describe('getConfig'), and the inferProviderForModel suppression test
moves out of describe('inferPersistableProviderForModel').

* ci: run make check in the CI check job

Replace the duplicated per-step lint/format/knip/typecheck/db-schema
parity steps (continue-on-error plus an aggregate failure step) and the
standalone no-comments/space-task/test-matrix/online-shards steps with
the same make check mega-target local devs run. Bump the job timeout to
5 minutes and make exact version pins a hard-failing step.

* fix(scripts): preserve token boundaries when stripping inline comments

Insert a single space when the characters adjacent to a removed inline
comment are both identifier-continuation characters, so
typeof/* note */value strips to typeof value instead of merging into
typeofvalue. Punctuator-adjacent merges are excluded: they cannot arise
from valid code without already being a syntax error, and spacing them
would regress clean output like value./* member */prop.

* fix(scripts): preserve line terminators from removed block comments

Restricted productions (return/throw/break/continue/yield) treat a line
terminator inside a comment as significant, so return/* note
 */1 must
strip to return
1 rather than return 1. The stripper now emits a newline
separator when the removed comment spanned lines and either the ... (continued)

44782 of 60177 branches covered (74.42%)

Branch coverage included in aggregate %.

60815 of 72583 relevant lines covered (83.79%)

4042.07 hits per line