ThePalaceProject / web-patron / 32540627485

30%

push

github

Add translations for French, Italian, German, and Spanish (PP-4710) (#187)

## Description

<!--- Describe your changes -->
Adds translations for French, Italian, German, and Spanish using a newly
created Claude Code skill.

#### New Claude Code skill `/translate`
A Claude Code skill `/translate` was added for translating English into
any of the secondary locales present in the codebase. The skill
references `.claude/skills/translate/references/glossary.md` to make
informed choices based on particularities for each locale as well as
balancing how certain words and phrases would be interpreted by native
users encountering these words in a library context.

#### Handle translations for facets
Facets are pulled back from `circulation` on collection feeds. We do not
currently send locale data to the Palace Circulation Manager, so the
collections are unaware of the current locale for the application. Even
so, `circulation` only provides facet labels and values in English.
`facets.ts` has been added to map the facet values found in
`src/palace/manager/feed/facets/constants.py` in `circulation` to
translation keys so that the application can render locale-aware facet
labels and values.

#### German translations
Support for German has been added in these changes. It had been
erroneously not included in the previous PR that added Spanish, Italian,
and French.

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
A previous PR
([#184](https://github.com/ThePalaceProject/web-patron/pull/184)) added
the scaffolding for translations. These changes provide the actual
non-English translations. This also brings the CPW into further parity
with the mobile apps.

[Jira [PP-4710](https://ebce-lyrasis.atlassian.net/browse/PP-4710)]

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing ... (continued)

331 of 1472 branches covered (22.49%)

Branch coverage included in aggregate %.

715 of 2059 relevant lines covered (34.73%)

9.53 hits per line