NVIDIA / gpu-operator / 32537025315

39%

main: 38%

push

github

Mount host /lib/modules for precompiled drivers on SUSE

getDriverAdditionalConfigs placed the lib-modules volume and mount inside
the "if !cr.Spec.UsePrecompiledDrivers()" branch, guarded by a check for
UsePrecompiledDrivers. That inner condition can never hold there, so an
NVIDIADriver with usePrecompiled: true on sles or sl-micro rendered a
driver pod without /run/host/lib/modules.

Pair the mount with the non-precompiled branch as an else instead of
re-testing the same predicate. The two paths are mutually exclusive, and
saying so once gives precompiled-only logic an obvious home. The comment
above the mount goes with it, since the else already says precompiled, the
guard already says SUSE and the volume literals already say host module
tree.

The equivalent code in the ClusterPolicy path sits before the early return
for precompiled drivers and works as intended, so only the NVIDIADriver
path was affected. That is also why this went unnoticed: the tests added
with the mount only covered the ClusterPolicy path.

Add a table-driven test that renders the DaemonSet and asserts the volume
on the pod spec and the mount on nvidia-driver-ctr. Going through the
render catches a template change that stopped threading AdditionalConfigs
into the pod as well as the Go-side bug.

Fixes #2776

Signed-off-by: Abrar Shivani <ashivani@nvidia.com>

16 of 16 new or added lines in 1 file covered. (100.0%)

5617 of 14542 relevant lines covered (38.63%)

0.44 hits per line