• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 32509711972
86%

Build:
DEFAULT BRANCH: main
Ran 21 Aug 2026 05:47PM UTC
Jobs 1
Files 257
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Aug 2026 05:44PM UTC coverage: 88.085% (+0.02%) from 88.062%
32509711972

push

github

web-flow
Abort the response stream when sending the payload continuation fails (#4843)

Fixes #4789.

`SendResponseAsync` seeded `flushResult` with `isCanceled: true` so that
a throw from the first `CopyFromAsync` would complete the payload writer
abortively. It never re-armed this sentinel before copying the payload
continuation, so a throw from that second copy left the successful
result of the first copy in place: the `finally` completed the payload
writer gracefully, the stream ended with a `StreamLast` frame, and the
client read the truncated payload as a complete, successful response.

Exceptions from that second copy are ordinary rather than contract
violations — `CopyFromAsync` lets reader exceptions escape, and the
reader is the application's async enumerable for a server-streaming
Slice or Protobuf operation.

This PR mirrors the request side, which was already correct: a
`payloadWriterSuccess` flag declared outside the `try` and set only
after the last copy completes. Every non-throwing path keeps its current
behavior, including the one where the first copy reports the peer is no
longer reading.


`PayloadContinuation_completed_on_invalid_response_payload_continuation`
drove this path but tolerated either outcome in its cleanup; it now
asserts the client always observes `IceRpcError.TruncatedData`, whether
the invocation itself fails or the failure surfaces when reading the
response payload.

## What's Changed entry

Area: Core

- Fixed a bug where a response payload could be silently truncated: when
a failure (such as an error reading
the payload from the application) interrupted the streaming of this
payload, the client received the
  truncated payload as if it was complete.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

4 of 4 new or added lines in 1 file covered. (100.0%)

10 existing lines in 3 files now uncovered.

12375 of 14049 relevant lines covered (88.08%)

3031.74 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
74.63
-4.48% src/IceRpc/Transports/Slic/Internal/SlicPipeReader.cs
2
91.94
0.54% src/IceRpc/Server.cs
2
90.62
0.09% src/IceRpc/Transports/Slic/Internal/SlicConnection.cs
Jobs
ID Job ID Ran Files Coverage
1 32509711972.1 21 Aug 2026 05:47PM UTC 3841
15.6
GitHub Action Run
Source Files on build 32509711972
  • Tree
  • List 257
  • Changed 206
  • Source Changed 1
  • Coverage Changed 206
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #32509711972
  • 6f5ccefa on github
  • Prev Build on main (#32500963143)
  • Next Build on main (#32509780339)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc