• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

icerpc / icerpc-csharp / 32500761884
86%

Build:
DEFAULT BRANCH: main
Ran 21 Aug 2026 04:04PM UTC
Jobs 1
Files 257
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Aug 2026 04:01PM UTC coverage: 88.02% (+0.1%) from 87.915%
32500761884

push

github

web-flow
Wait for detached connections when shutting down a client connection (#4844)

Fixes #4793.

`ClientConnection.PerformShutdownAsync` awaited the active connection's
shutdown and the detached-connections wait sequentially inside a single
`try`, followed by a `catch` that ignored shutdown failures. Both
protocol implementations rethrow a non-`OperationCanceledException`
`IceRpcException` from `ShutdownAsync`, so a failing active connection
jumped past the detached-connections wait and `ShutdownAsync` reported
success while detached connections were still shutting down.

This PR mirrors `ConnectionCache.PerformShutdownAsync` and
`Server.PerformShutdownAsync`: a single `Task.WhenAll` over both, in the
same nested-try shape, so a shutdown failure is ignored without skipping
the wait. The `OperationCanceledException` translation to
`OperationAborted` / `TimeoutException` is unchanged.

The `ShutdownAsync` doc comment listed an `IceRpcException` "if the
connection shutdown failed", which this method does not throw, and
omitted the `OperationAborted` it does throw when the connection is
disposed mid-shutdown. It now uses the same wording as its
`ConnectionCache` and `Server` counterparts.

## What's Changed entry

None — internal: the shutdown could misreport completion in a window
that disposal already covered.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

8 of 12 new or added lines in 1 file covered. (66.67%)

5 existing lines in 3 files now uncovered.

12365 of 14048 relevant lines covered (88.02%)

3022.07 hits per line

Uncovered Changes

Lines Coverage ∆ File
4
82.55
-0.55% src/IceRpc/ClientConnection.cs

Coverage Regressions

Lines Coverage ∆ File
2
82.55
-0.55% src/IceRpc/ClientConnection.cs
2
91.94
-0.36% src/IceRpc/Server.cs
1
91.74
-0.11% src/IceRpc/Internal/IceRpcProtocolConnection.cs
Jobs
ID Job ID Ran Files Coverage
1 32500761884.1 21 Aug 2026 04:04PM UTC 3841
15.59
GitHub Action Run
Source Files on build 32500761884
  • Tree
  • List 257
  • Changed 195
  • Source Changed 1
  • Coverage Changed 195
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #32500761884
  • 57ec8ed0 on github
  • Prev Build on main (#32500677740)
  • Next Build on main (#32500963143)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc