kubernetes-sigs / external-dns / 32500379414
82%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 159
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 81.979% (+0.1%) from 81.862%
32500379414

push

github

web-flow 
fix(source): evaluate FQDN templates on typed objects like unstructured (#6611)

* fix(source): evaluate FQDN templates on typed objects like unstructured

Retry failed FQDN template execution with an unstructured-style data
shape so shared templates using JSON keys under Spec (e.g.
.Spec.hostnames) work for gateway-httproute as well as unstructured.


Signed-off-by: zanarelli <zanarelli.dev@gmail.com>

* test(source): cover JSON-style FQDN template on typed HTTPRoute

Adds an integration-level test through the real gateway route resolver
(not just source/template/engine_test.go's isolated unit tests) proving
a JSON-style Spec.hostnames template now evaluates successfully against
a typed HTTPRoute via the unstructured fallback, matching the exact
scenario and error from #6593.

* style: trim comments, drop issue-number refs per review

Shortened the fallback comment in engine.go and the corresponding test
doc comments; removed the #6593 references from code comments per
ivankatliarchuk's review.

* fix(source): resolve JSON-key casing on unstructured spec/status fields

A map key miss in text/template renders empty instead of erroring, so
templates on the unstructured source silently produced nothing when
using the Go field name casing (.Spec.Hostnames) instead of the raw
JSON key (.Spec.hostnames). Alias each map key to its title-cased form
so both spellings resolve.

* refactor(source/template): dedupe template error wrapping in execTemplate

Extract wrapTemplateErr to remove the duplicated kind/namespace/name
formatting between the two retry error paths, and propagate the
retry's own error instead of re-wrapping the original one.

* test(source): move title-case alias coverage into example table

* fix(source): three template-retry regressions flagged by review

mloiseleur found three real regressions in the FQDN-template typed/
unstructured retry added earlier in this branch, each with a reproducing
test:

- The unstructured retry in execTemplate ... (continued)

17714 of 21608 relevant lines covered (81.98%)

1446.21 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
79.09
 13.35% template/engine.go
4
97.06
 -0.83% unstructured.go
1
86.07
 -0.82% openshift_route.go
Jobs
ID Job ID Ran Files Coverage
1 run-macos-latest - 32500379414.1 159
81.98
 GitHub Action Run
2 run-ubuntu-latest - 32500379414.2 159
81.98
 GitHub Action Run
Source Files on build 32500379414