decentraland / atlas-server / 32498039887

42%

master: 41%

Pull #144

github

fix: apply the V3 trade status semantics to the map query

atlas-server is the second consumer of squid_trades and its query carried
every defect just fixed in marketplace-server. Since getActiveTrades feeds
the map, the symptom is parcels and estates showing as for sale when they are
not.

Cancellations counted any row regardless of who cancelled. cancelSignature
takes no signer check, and the contract scopes the flag to
keccak256(caller, digest) while settlement reads keccak256(signer, digest),
so a stranger cancelling is a no-op on chain - anyone could grief a listing
off the map while it stayed settleable.

Cancellations were matched only on keccak256(signature bytes), so V3, which
keys them on the trade's EIP-712 digest, would never have resolved and
cancelled V3 land would have stayed on the map indefinitely.

The signer index was matched on address alone. A row's identity is
address + contract + network, so that returned several rows and split one
trade into several GROUP BY groups with contradictory statuses - and because
this query keeps only status = open, the stale group survived.

The contract index was a hardcoded list holding only the Ethereum V1 address,
joined by network, so it never described the marketplace a trade targets.

Executed fills were counted per joined asset row rather than per indexer row,
so a multi-use listing read sold early.

298 of 412 branches covered (72.33%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 1 file covered. (100.0%)

1488 of 3886 relevant lines covered (38.29%)

11.95 hits per line