decentraland / marketplace-server / 32496092712

63%

main: 62%

Pull #395

github

fix: match contract index rows on their holder as well

A signature_index row's identity became address + contract + network when the
squid started recording which deployment holds each counter, so address plus
network is no longer unique. The contract-index joins still matched on address
alone, which could reach a signer row keyed to this address under a different
holder and match more than one row where the join must match at most one -
the duplicate-group hazard just fixed for the signer join, reintroduced from
the other side by that schema change.

Both joins and the view are now exact on the whole identity. Regression cases
cover a row keyed to the trade's marketplace but held by another, which must
leave the trade open, and the marketplace bumping its own counter, which must
cancel it. Removing the new predicate fails the first and nothing else.

1721 of 3155 branches covered (54.55%)

Branch coverage included in aggregate %.

31 of 35 new or added lines in 4 files covered. (88.57%)

3096 of 4539 relevant lines covered (68.21%)

27.05 hits per line