decentraland / marketplace-server / 32493070566

63%

main: 62%

Build Type

Pull #395

github

Committed by LautaroPetaccio

Commit Message

fix: scope the signer index join to the trade's marketplace

signerSignatureIndex is a mapping in each marketplace deployment's own
storage, so the same signer holds independent counters on V2 and V3, and a
trade signed the one it read from the version it targets. Joining on signer
and network alone could not tell them apart, so a bump on one version
cancelled trades signed against another, and a lower counter from a later
version made genuinely revoked trades read open.

Pairs with trades-squid-core recording the emitting marketplace on each
signature_index row. The integration test now asserts both index joins carry
their contract scope in the definition Postgres compiled.

Pull Request Pull Request #395: feat: support off-chain marketplace v3 trades

Coverage Stats

1721 of 3155 branches covered (54.55%)

Branch coverage included in aggregate %.

31 of 35 new or added lines in 4 files covered. (88.57%)

23 existing lines in 2 files now uncovered.

3096 of 4539 relevant lines covered (68.21%)

27.05 hits per line