decentraland / marketplace-server / 32491139107

63%

main: 62%

Build Type

Pull #395

github

Committed by LautaroPetaccio

Commit Message

feat: migrate mv_trades to the current definition, and cover it

Migration 1739898312357 created the view and was never updated, while every
later change went into recreateTradesMaterializedView. A database that was
only ever migrated therefore computed trade status with the original rules
until an operator called the recreate endpoint.

The view definition and its indexes are now exported constants applied by
both paths, so they cannot drift again, and a migration brings an existing
database up to them. That migration is deliberately not frozen: replaying it
after a later change yields the newer definition, which is what you want for
a derived object holding no state of its own.

The view had no coverage at all. Its definition was never executed by any
test, so a syntax error, a column the indexer schema lacks or a missing role
only surfaced in production. There is now an integration test that calls the
endpoint for real and asserts the compiled definition Postgres stored -
either-identifier matching, the signer-only cancellation guard, and the
network translation on both signature index joins.

Getting it to run turned up two undeclared dependencies of the endpoint, both
added to the test fixture: it grants to a dappsdata role, and it reads squids
and indexers unqualified, which resolve in the marketplace schema because
that connection runs with search_path=marketplace.

Pull Request Pull Request #395: feat: support off-chain marketplace v3 trades

Coverage Stats

1721 of 3155 branches covered (54.55%)

Branch coverage included in aggregate %.

31 of 35 new or added lines in 4 files covered. (88.57%)

25 existing lines in 2 files now uncovered.

3096 of 4539 relevant lines covered (68.21%)

27.05 hits per line