decentraland / marketplace-server / 32489625599

63%

main: 62%

Build Type

Pull #395

github

Committed by LautaroPetaccio

Commit Message

fix: only count the signer's own cancellation, and scope the signer index

Three status bugs, all reachable today.

cancelSignature takes no signer check, and the contract scopes the flag to
keccak256(caller, digest) while settlement reads keccak256(signer, digest), so
a stranger cancelling somebody's trade is a no-op on chain. The status queries
counted any cancelled row regardless of who cancelled, so anyone could grief a
listing into reading cancelled while it stayed settleable, using trade data the
API already publishes. Now only a cancellation by the trade's own signer counts.

The signer signature index joined on address with no network predicate. A
signer with rows on both networks matched twice, duplicating the trade into two
GROUP BY groups with contradictory statuses, which breaks the unique index that
REFRESH CONCURRENTLY needs, and let an Ethereum bump cancel Polygon trades.
Scoped by network, translating MATIC to the indexer's POLYGON.

Executed fills were counted with COUNT(CASE ...) while the asset join
multiplies every trade into one row per asset, so each fill counted twice and a
multi-use listing read sold early. Since getOpenItemOrderQuery is the
duplicate-listing guard, a false sold admitted a second listing for an item
that already had one. Counts distinct indexer rows now, matching the view.

Pull Request Pull Request #395: feat: support off-chain marketplace v3 trades

Coverage Stats

1721 of 3155 branches covered (54.55%)

Branch coverage included in aggregate %.

29 of 30 new or added lines in 3 files covered. (96.67%)

22 existing lines in 2 files now uncovered.

3094 of 4540 relevant lines covered (68.15%)

27.03 hits per line