decentraland / marketplace-server / 32484617117

63%

main: 62%

Build Type

Pull #395

github

Committed by LautaroPetaccio

Commit Message

fix: match the contract signature index on the trade's own marketplace

The contract index rows were joined by network only, after filtering every
known marketplace address. Each marketplace version keeps an independent
contractSignatureIndex, and a trade signs the value it read from the version
it targets, so a bump on one version made trades signed against another look
revoked and report as cancelled.

Joined on the trade's stored contract instead, which also means exactly one
row matches per trade. Pairs with trades-squid-core recording contract index
bumps under the emitting log.address; per-version rows matched by network
alone would have multiplied trades through this LEFT JOIN.

Removes the interpolated marketplace address list from these queries along
with the helper that built it, since the join no longer needs it.

Pull Request Pull Request #395: feat: support off-chain marketplace v3 trades

Coverage Stats

1721 of 3155 branches covered (54.55%)

Branch coverage included in aggregate %.

26 of 27 new or added lines in 3 files covered. (96.3%)

1 existing line in 1 file now uncovered.

3091 of 4537 relevant lines covered (68.13%)

26.97 hits per line