decentraland / builder / 32483677631

53%

master: 53%

Pull #3473

github

fix: revoke every held marketplace version when disabling off-chain sale

enableSaleOffchain only revoked the newest version, so a collection holding
V2 minter rights kept them after the user turned off-chain sale off: listings
on that version stayed sellable, and isEnableForSaleOffchain - which accepts
any deployed version - still reported the collection as on sale.

Enabling still grants the newest version only, since the minter has to be the
contract the trade was signed against. Disabling now revokes every version
the collection actually holds, falling back to the newest when it holds none
so the contract never receives empty arrays.

2445 of 5783 branches covered (42.28%)

Branch coverage included in aggregate %.

20 of 21 new or added lines in 1 file covered. (95.24%)

7531 of 13035 relevant lines covered (57.78%)

35.51 hits per line