• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

LFDT-Panurus / panurus / 32467158141
85%

Build:
DEFAULT BRANCH: main
Ran 21 Aug 2026 09:35AM UTC
Jobs 68
Files 546
Run time 5min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Aug 2026 09:17AM UTC coverage: 83.738% (+0.001%) from 83.737%
32467158141

push

github

AkramBitar
fix(network): fill same-MSP endorser slots with distinct identities

SelectEndorsersForMSPSets sampled one configured endorser per required MSP ID
of a candidate set without excluding identities already picked for an earlier
slot of that same set. A namespace endorsement policy requiring two signers
from one MSP - e.g. AND(Org1MSP.member, Org1MSP.member), whose principal set
inquire.SatisfiedBy() reports as ["Org1MSP", "Org1MSP"] - could therefore be
satisfied by asking a single endorser to sign twice, collapsing the intended
2-of-N-within-org guarantee onto a single point of trust.

Per-slot sampling now excludes identities already selected for the same
candidate set, so every returned identity is distinct and the result length
always matches the chosen candidate set. A set requiring more distinct signers
from an MSP than that MSP has configured endorsers is no longer satisfiable and
is skipped, leaving the caller to try the remaining candidate sets before
failing - correctness over availability, as elsewhere in this selector.

Duplicate entries in the configured endorser list now collapse to a single
candidate: such a duplicate denotes one endorser providing one endorsement, so
counting it twice both skewed the uniform random pick and overstated how many
distinct endorsers an MSP actually offers.

selectDistinctForMSPSet returns ([]view.Identity, string, bool): the string
carries the first MSP ID whose pool was exhausted, so the caller can include it
in the error message. The error now reads:

  MSP [Org1MSP] requires 2 distinct endorser(s) but only 1 configured

making operator configuration errors immediately diagnosable.

The SelectEndorsersForMSPSets godoc says "distinct by identity bytes" rather
than just "distinct", to match what the code actually enforces (byte equality)
and distinguish it from the key-equality check in endorserForThresholdRule.

Signed-off-by: Hayim.Shaul@ibm.com <hayimsha@fhe03.vpc.cloud9.ibm.com>
Signed-off-by: Akram Bitar... (continued)

38 of 38 new or added lines in 1 file covered. (100.0%)

12 existing lines in 5 files now uncovered.

44330 of 52939 relevant lines covered (83.74%)

12176.83 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
83.02
-0.69% token/services/storage/db/sql/common/transactions.go
2
79.06
-0.55% token/services/network/fabric/network.go
2
72.92
-1.04% token/services/storage/auditdb/store.go
2
82.57
-1.83% token/services/storage/db/sql/common/keystore.go
2
77.95
-0.79% token/services/storage/ttxdb/store.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabtoken-dlog-fabric - 32467158141.1 21 Aug 2026 09:52AM UTC 485
41.49
GitHub Action Run
2 itest-dloghsm-fabric-t1-websocket - 32467158141.2 21 Aug 2026 09:45AM UTC 485
42.37
GitHub Action Run
3 itest-update-t3 - 32467158141.3 21 Aug 2026 09:52AM UTC 485
38.23
GitHub Action Run
4 itest-fabricx-dlog-t1-websocket - 32467158141.4 21 Aug 2026 09:47AM UTC 505
43.96
GitHub Action Run
5 itest-dlog-fabric-t6-libp2p - 32467158141.5 21 Aug 2026 09:44AM UTC 485
41.89
GitHub Action Run
6 itest-dlog-fabric-t5 - 32467158141.6 21 Aug 2026 09:42AM UTC 485
38.69
GitHub Action Run
7 itest-fabricx-dlog-t16-websocket - 32467158141.7 21 Aug 2026 09:47AM UTC 505
44.14
GitHub Action Run
8 itest-dlog-fabric-t6-websocket - 32467158141.8 21 Aug 2026 09:44AM UTC 485
42.12
GitHub Action Run
9 itest-nft-fabtoken - 32467158141.9 21 Aug 2026 09:38AM UTC 481
29.83
GitHub Action Run
10 itest-dlog-fabric-t11 - 32467158141.10 21 Aug 2026 09:43AM UTC 485
32.89
GitHub Action Run
11 itest-fabricx-dlog-t11 - 32467158141.11 21 Aug 2026 09:42AM UTC 505
34.53
GitHub Action Run
12 itest-dlog-fabric-t13 - 32467158141.12 21 Aug 2026 09:42AM UTC 485
36.31
GitHub Action Run
13 itest-dlog-fabric-t1-libp2p - 32467158141.13 21 Aug 2026 09:44AM UTC 485
42.05
GitHub Action Run
14 itest-fabricx-dlog-t4 - 32467158141.14 21 Aug 2026 09:39AM UTC 505
40.64
GitHub Action Run
15 itest-fabricx-dlog-t13 - 32467158141.15 21 Aug 2026 09:40AM UTC 505
38.35
GitHub Action Run
16 itest-dlog-fabric-t8-libp2p - 32467158141.16 21 Aug 2026 09:44AM UTC 485
42.28
GitHub Action Run
17 itest-fabtoken-fabric-t4 - 32467158141.17 21 Aug 2026 09:41AM UTC 485
30.68
GitHub Action Run
18 itest-fabtoken-fabric-t1-websocket - 32467158141.18 21 Aug 2026 09:43AM UTC 485
34.22
GitHub Action Run
19 itest-dvp-fabtoken - 32467158141.19 21 Aug 2026 09:40AM UTC 481
31.39
GitHub Action Run
20 itest-dlog-fabric-t6-replicas - 32467158141.20 21 Aug 2026 09:46AM UTC 485
43.37
GitHub Action Run
21 itest-fabricx-dlog-t3 - 32467158141.21 21 Aug 2026 09:39AM UTC 505
38.55
GitHub Action Run
22 itest-interop-fabtoken-t4 - 32467158141.22 21 Aug 2026 09:42AM UTC 485
31.01
GitHub Action Run
23 itest-dlog-fabric-t1-replicas - 32467158141.23 21 Aug 2026 09:46AM UTC 485
43.89
GitHub Action Run
24 itest-interop-fabtoken-t5 - 32467158141.24 21 Aug 2026 09:43AM UTC 485
31.65
GitHub Action Run
25 itest-dlog-fabric-t8-websocket - 32467158141.25 21 Aug 2026 09:44AM UTC 485
42.1
GitHub Action Run
26 itest-interop-fabtoken-t1 - 32467158141.26 21 Aug 2026 09:43AM UTC 485
33.2
GitHub Action Run
27 itest-fabtoken-fabric-t5 - 32467158141.27 21 Aug 2026 09:40AM UTC 485
30.68
GitHub Action Run
28 itest-fabricx-dlog-t1-libp2p - 32467158141.28 21 Aug 2026 09:46AM UTC 505
43.92
GitHub Action Run
29 itest-interop-fabtoken-t3 - 32467158141.29 21 Aug 2026 09:45AM UTC 485
32.22
GitHub Action Run
30 itest-dlog-fabric-t3 - 32467158141.30 21 Aug 2026 09:40AM UTC 485
37.25
GitHub Action Run
31 utest-unit-tests-race - 32467158141.31 21 Aug 2026 09:39AM UTC 545
74.62
GitHub Action Run
32 itest-dloghsm-fabric-t2-websocket - 32467158141.32 21 Aug 2026 09:45AM UTC 485
42.62
GitHub Action Run
33 itest-nft-dlog - 32467158141.33 21 Aug 2026 09:38AM UTC 485
37.2
GitHub Action Run
34 utest-unit-tests-regression - 32467158141.34 21 Aug 2026 09:38AM UTC 545
74.62
GitHub Action Run
35 itest-fabtoken-fabric-t1-replicas - 32467158141.35 21 Aug 2026 09:45AM UTC 485
35.09
GitHub Action Run
36 itest-update-t1 - 32467158141.36 21 Aug 2026 09:44AM UTC 485
42.53
GitHub Action Run
37 itest-update-t2 - 32467158141.37 21 Aug 2026 09:46AM UTC 485
37.65
GitHub Action Run
38 itest-dvp-dlog - 32467158141.38 21 Aug 2026 09:39AM UTC 485
38.63
GitHub Action Run
39 itest-dlog-fabric-t2.1 - 32467158141.39 21 Aug 2026 09:45AM UTC 485
33.63
GitHub Action Run
40 itest-fabricx-dlog-t5 - 32467158141.40 21 Aug 2026 09:39AM UTC 505
40.61
GitHub Action Run
41 itest-fabtoken-fabric-t1-libp2p - 32467158141.41 21 Aug 2026 09:44AM UTC 485
34.18
GitHub Action Run
42 itest-fabtoken-fabric-t2 - 32467158141.42 21 Aug 2026 09:45AM UTC 485
27.59
GitHub Action Run
43 itest-fabtoken-fabric-t3 - 32467158141.43 21 Aug 2026 09:40AM UTC 485
29.39
GitHub Action Run
44 itest-dlog-fabric-t4 - 32467158141.44 21 Aug 2026 09:41AM UTC 485
38.7
GitHub Action Run
45 itest-dlog-fabric-t1-websocket - 32467158141.45 21 Aug 2026 09:44AM UTC 485
42.14
GitHub Action Run
46 itest-fabricx-dlog-t6-websocket - 32467158141.46 21 Aug 2026 09:46AM UTC 505
44.19
GitHub Action Run
47 itest-dlog-fabric-t8-replicas - 32467158141.47 21 Aug 2026 09:46AM UTC 485
44.19
GitHub Action Run
48 itest-interop-dlog-t1 - 32467158141.48 21 Aug 2026 09:43AM UTC 485
41.23
GitHub Action Run
49 itest-dlog-fabric-t2 - 32467158141.49 21 Aug 2026 09:46AM UTC 485
33.88
GitHub Action Run
50 itest-interop-dlog-t5 - 32467158141.50 21 Aug 2026 09:44AM UTC 485
39.66
GitHub Action Run
51 itest-dloghsm-fabric-t1-replicas - 32467158141.51 21 Aug 2026 09:46AM UTC 485
43.54
GitHub Action Run
52 itest-dlog-fabric-t9 - 32467158141.52 21 Aug 2026 09:39AM UTC 485
34.21
GitHub Action Run
53 itest-fabricx-dlog-t16-replicas - 32467158141.53 21 Aug 2026 09:49AM UTC 505
45.88
GitHub Action Run
54 itest-dloghsm-fabric-t2-replicas - 32467158141.54 21 Aug 2026 09:44AM UTC 485
43.76
GitHub Action Run
55 itest-fabricx-dlog-t6-replicas - 32467158141.55 21 Aug 2026 09:48AM UTC 505
45.92
GitHub Action Run
56 itest-dlog-fabric-t10-replicas - 32467158141.56 21 Aug 2026 09:46AM UTC 485
46.65
GitHub Action Run
57 itest-dlog-fabric-t7 - 32467158141.57 21 Aug 2026 09:44AM UTC 485
34.07
GitHub Action Run
58 itest-dloghsm-fabric-t1-libp2p - 32467158141.58 21 Aug 2026 09:45AM UTC 485
41.95
GitHub Action Run
59 itest-dlogstress-t1 - 32467158141.59 21 Aug 2026 09:35AM UTC 485
37.31
GitHub Action Run
60 itest-fabricx-dlog-t6-libp2p - 32467158141.60 21 Aug 2026 09:47AM UTC 505
44.16
GitHub Action Run
61 itest-interop-dlog-t3 - 32467158141.61 21 Aug 2026 09:46AM UTC 485
40.27
GitHub Action Run
62 itest-dlog-fabric-t10-libp2p - 32467158141.62 21 Aug 2026 09:44AM UTC 485
44.81
GitHub Action Run
63 itest-interop-dlog-t4 - 32467158141.63 21 Aug 2026 09:44AM UTC 485
38.84
GitHub Action Run
64 itest-fabricx-dlog-t1-replicas - 32467158141.64 21 Aug 2026 09:49AM UTC 505
45.67
GitHub Action Run
65 itest-dlog-fabric-t10-websocket - 32467158141.65 21 Aug 2026 09:43AM UTC 485
44.58
GitHub Action Run
66 itest-fabricx-dlog-t16-libp2p - 32467158141.66 21 Aug 2026 09:47AM UTC 505
44.11
GitHub Action Run
67 itest-dloghsm-fabric-t2-libp2p - 32467158141.67 21 Aug 2026 09:44AM UTC 485
42.07
GitHub Action Run
68 itest-dlog-fabric-t12 - 32467158141.68 21 Aug 2026 09:41AM UTC 485
39.83
GitHub Action Run
Source Files on build 32467158141
  • Tree
  • List 546
  • Changed 93
  • Source Changed 1
  • Coverage Changed 93
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #32467158141
  • 96ab4d0c on github
  • Prev Build on main (#32396470389)
  • Next Build on main (#32528227259)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc