lsm / HyperNeo / 32439900304

80%

push

github

fix(daemon): restore unconditional automatic pre-migration backups (#2631)

* fix(daemon): restore unconditional automatic pre-migration backups (#1177)

PR #2621 skipped the pre-migration backup for DBs over 1 GiB
(HYPERNEO_DB_MIGRATION_BACKUP_MAX_BYTES), leaving large production DBs
unprotected during upgrades. Every migration now gets a backup again,
unconditionally; the env bound is removed entirely.

The blocking cost that motivated the skip is eliminated by picking a
fast snapshot path per attempt, fastest first, with the chosen strategy
and duration logged:

- fs-copy (Bun, the pinned runtime): copyFileSync clonefiles on APFS
  and reflinks via copy_file_range on btrfs/XFS; a non-empty -wal
  sidecar is copied so committed WAL frames survive the snapshot.
- vacuum-into (non-Bun runtimes): VACUUM INTO produces a consistent,
  compacted snapshot including committed WAL content, with no upfront
  wal_checkpoint(TRUNCATE) stall.
- checkpoint-copy (last resort): checkpoint + full-file copy, the old
  behavior.

Backup retention stays at 3, now pruning -wal sidecars with their
backups. Verified on a 28.9 GiB production clone: the fs-copy backup
completed in 0-1 ms with ~0 net disk (APFS clone), the backup passed
PRAGMA integrity_check, and restarts with no pending migrations create
no backup. db-maintenance.md updated accordingly.

* fix(daemon): discard incomplete fs-copy backups on WAL sidecar failure

Review feedback on #2631: a failed -wal sidecar copy was swallowed with
a warning while the fs-copy backup was still reported as created,
leaving a snapshot that silently lacks recently committed WAL frames.

copyWalSidecar now reports success; when a non-empty WAL exists but its
sidecar copy fails, the partial artifacts (db and -wal) are removed and
the cascade falls through to VACUUM INTO, which produces a
self-contained snapshot. The checkpoint-copy last resort fails closed
the same way instead of reporting success with a stale copy, and
VACUUM IN... (continued)

44432 of 59837 branches covered (74.26%)

Branch coverage included in aggregate %.

76 of 92 new or added lines in 1 file covered. (82.61%)

60380 of 72157 relevant lines covered (83.68%)

3971.18 hits per line