decentraland / marketplace-server / 32411217208

63%

main: 62%

Build Type

Pull #395

github

Committed by LautaroPetaccio

Commit Message

fix: only store a trade digest for versions keyed on one

resolveTradeSignature stored the EIP-712 digest for whichever marketplace
version matched, including V2. The indexer only records a digest for V3, so
the two trade_digest columns did not mean the same thing on each side of the
join, and the join's correctness rested on the indexer side happening to be
null rather than on the columns agreeing.

The version check now happens once, where the contract is already known,
instead of per row in SQL: the digest is stored only for versions that key
cancellations on it. A V1/V2 trade can now only ever match through
hashed_signature and a V3 one only through the digest.

Pull Request Pull Request #395: feat: support off-chain marketplace v3 trades

Coverage Stats

1721 of 3155 branches covered (54.55%)

Branch coverage included in aggregate %.

36 of 41 new or added lines in 4 files covered. (87.8%)

1 existing line in 1 file now uncovered.

3103 of 4553 relevant lines covered (68.15%)

27.3 hits per line