lsm / HyperNeo / 32405128686

80%

push

github

perf(daemon): memoize session task-id resolution on message save (#2615)

* perf(daemon): memoize session task-id resolution on message save

resolveTaskIdForSession ran twice per saved message: once in
SDKMessageRepository to stamp sdk_messages.task_id and again in the
reactive layer's sdkMessageScope to build the change-notification scope.
The sessions query with json_extract ran on every save.

Share a per-database memo cache between the repo and the reactive scope
so the second lookup hits the cache (0 hot queries after warm-up).
Invalidate on session writes that touch context/type, on delete, and on
transaction abort so cached task ids never go stale.

* fix(daemon): address resolveTaskIdForSession review findings

- Do not memoize a null taskId when the sessions query throws, so a
  transient resolution failure does not permanently strip task
  attribution for subsequent messages.
- Invalidate the taskId cache before the session write runs, so a write
  that throws after partially applying still clears the stale entry.
- Add resolveTaskIdForSession to the noOpReactiveDb test helper to
  satisfy the widened ReactiveDatabase interface.

Adds regression tests for the non-memoized failure path and for
invalidation surviving a throwing session write.

* chore(daemon): drop comments from task-id cache test

* test(daemon): add rowid tiebreak to task-id ordering in cache test

44189 of 59621 branches covered (74.12%)

Branch coverage included in aggregate %.

34 of 36 new or added lines in 3 files covered. (94.44%)

60088 of 71875 relevant lines covered (83.6%)

3864.48 hits per line