archetech / archon / 32401592846

95%

push

github

test: Stop a cwd leak in wallet-db from failing cli-parity (#907)

wallet-db.test.ts chdirs into a temp dir, because WalletSQLite's default path
is relative to the working directory and that is the thing under test. The
paired try/finally covers a thrown assertion but not a jest timeout, which
abandons the pending body and moves on -- leaving the process in the temp dir.

cwd is process-global and the unit suite runs --runInBand, so cli-parity.test.ts,
which read its sources relative to process.cwd(), then died with an ENOENT
naming a temp directory. The reported failure pointed at the wrong file.

Fix both ends: cli-parity resolves from its own location via import.meta.url,
so no other suite's cwd can reach it; and wallet-db restores cwd in afterEach,
which jest runs even after a timeout. A guard test asserts the suite leaves cwd
as it found it, so a regression reports as itself rather than as a stranger's
ENOENT.

Verified by running a suite that leaks cwd on purpose ahead of cli-parity,
which now passes.

Fixes #903

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

3773 of 4247 branches covered (88.84%)

Branch coverage included in aggregate %.

8433 of 8728 relevant lines covered (96.62%)

686.98 hits per line