NVIDIA / nodewright / 32398326397
83%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.363% (+3.1%) from 80.286%
32398326397

push

github

web-flow 
ci(operator): exclude generated deepcopy from reported coverage (#501)

* ci(operator): exclude generated deepcopy from reported coverage

zz_generated.deepcopy.go is ~916 statements at 49.8%, about a quarter of all
uncovered code in the repo. It is controller-gen output and nobody should
hand-write a test for DeepCopyInto, but nothing filtered it, so it cost roughly
4 points of the headline number and buried the coverage of code people write.
The legacy api/v1alpha1 copy sits near 29% purely because that CRD is read-only.

Adds COVERAGE_EXCLUDE to operator/Makefile as the single definition, applied by
a new filter-coverage target. merge-coverage now calls it, so per-suite
artifacts are filtered at the source, and the upload-coverage job calls it again
on the combined profile so a suite that starts uploading a raw profile cannot
quietly reintroduce the generated files.

This has to happen before upload: Coveralls has no exclusion mechanism for Go
profiles. There is no .coveralls.yml key for it and coverallsapp/github-action
has no such input, so it counts whatever profile it is handed.

Verified against the merged profile from the run on #493: 5619 blocks in,
480 excluded, 78.7% -> 82.4%.

Drive-by: the .PHONY line above merge-coverage read "merage-coverage", so the
target was never actually declared phony. Fixed, and both targets now carry ##
help text so they show up in make help.

Reported coverage steps up once when this merges. That is a measurement change,
not new testing.

Signed-off-by: Alex Yuskauskas <ayuskauskas@nvidia.com>

* ci(operator): refuse a coverage exclusion that would empty the profile

COVERAGE_EXCLUDE is overridable, and every way a bad value can go wrong ended in
the same place: an empty cover.out replacing a good one and reporting 0% to
Coveralls, with nothing in the log blaming the pattern.

  - an empty value makes `grep -v -E ''` match every line (exit 1)
  - a pattern broad enough to match everything does the same (exit 1... (continued)

10678 of 12809 relevant lines covered (83.36%)

8.51 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
80.22
 -0.18% operator/internal/controller/skyhook_controller.go
Jobs
ID Job ID Ran Files Coverage
1 32398326397.1 59
83.36
 GitHub Action Run
Source Files on build 32398326397