TOMToolkit / tom_jpl / 32398352241

91%

dev: 86%

Pull #23

github

Add individual-object fallback lookup for MPC designations

_fetch_mpc_prev_designations only scrapes the rolling ~100-entry "Previous
NEOCP Objects" table. If a FOMO outage outlasts that window, an object that
both left Scout and got designated during the gap scrolls off before the
next run ever sees it, and stays stuck under its Scout provisional name
forever -- nothing previously retried it individually.

The page's own "Submit" search box (a JS-driven AJAX POST to the same URL,
not a plain form submit -- confirmed via /static/neocp/js/neocp_prev_des.js
and tested end-to-end against a live object) supports exactly this: looking
up one trksub/designation directly. Add:

- _mpc_session_and_csrf_token(): GETs the page once to establish a session
  and scrape its CSRF token, reused across all individual lookups in a run
  rather than re-fetching per target.
- _fetch_mpc_prev_designation_for(session, csrf_token, trksub): POSTs the
  same request the page's button does and parses the returned JSON's HTML
  fragment (same table shape as the bulk page) via the row-parsing logic
  refactored out of _fetch_mpc_prev_designations into _parse_designation_rows
  so both paths share one implementation.
- Command._fallback_lookup_designations(): for every ScoutDetail(active=False)
  target not covered by this run's bulk table, does an individual lookup --
  skipping targets whose name already looks like a resolved IAU designation
  (contains a space or comet-style '/', which Scout trksubs never do), so
  already-resolved targets aren't re-queried forever. Merged into
  designation_map before the existing rename/collision-guard logic runs
  unchanged. Never raises: a failed session or a single failed lookup logs a
  warning and the rest of the run proceeds on whatever the bulk table found.

Verified against the live MPC page (a fallback canary test confirms the
individual-lookup endpoint agrees with the bulk table for a real object),
plus mocked unit/integration te... (continued)

605 of 655 new or added lines in 7 files covered. (92.37%)

1253 of 1382 relevant lines covered (90.67%)

0.91 hits per line