uber / h3 / 32396289015

100%

push

github

Fix out of bounds read in _baseCellToCCWrot60 for face == NUM_ICOSA_FACES (#1224)

The bounds check used > instead of >=, so a face index equal to
NUM_ICOSA_FACES (20) passed validation and indexed one element past the
end of faceIjkBaseCells[NUM_ICOSA_FACES][3][3][3].

Reproduced as an AddressSanitizer global-buffer-overflow at
baseCells.c:882 under the sanitizer flags the repo CI already uses. Adds
a regression test that aborts without the fix.

Fixes #978

1915 of 1925 branches covered (99.48%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

3401 of 3407 relevant lines covered (99.82%)

34580231.84 hits per line