decentraland / builder-server / 32372373794

72%

master: 72%

Build Type

Pull #809

github

Committed by LautaroPetaccio

Commit Message

fix(auth)!: migrate to @dcl/crypto-middleware 6 and harden the scene check

@dcl/platform-crypto-middleware has no release past 1.x, so it never
received the payload change that binds metadata casing to the signature.
Up to that version the signed payload folded the whole joined string, which
left two requests differing only in case sharing one valid signature while
consumers read the metadata exactly as delivered.

The scene check compared with an exact match and was sensitive to that gap
two ways: a delivered `Signer` made the `'signer' in` test false, and a
re-cased value made the `===` false. Either way it fell through and a
scene-originated request was classified as directly user-signed.

Replaces the dependency with @dcl/crypto-middleware ^6.2.0, whose payload
joins the metadata bytes verbatim, and routes the comparison through
rejectIfSigner, which refuses a signer that is not already canonical rather
than comparing it. Nothing is folded — the value reaching handlers is what
was signed. `isEIP1664AuthChain` becomes `isEIP1654AuthChain`, the same
logic under a corrected name.

The check stays on verify()'s success path rather than moving into
metadataValidator. A validator rejection throws out of verify(), which
would enter the catch below and let the validateSignature fallback clear
the error — so moving it would have made the scene check bypassable.

The fetcher needs a cast: crypto-middleware types it against
@dcl/core-commons, which accepts `string | URL | Request`, while this
service's comes from @well-known-components/interfaces and declares only
`Request`. The type is derived from verify() rather than imported, so no
transitive package is depended on, and the cast is safe because the
middleware passes a string URL that @well-known-components/fetch-component
accepts at runtime — confirmed by observing a string URL reach DNS
resolution rather than being rejected.

The spec previously auto-mocked the whole module, which would have left
rejec... (continued)

Pull Request Pull Request #809: fix(auth)!: migrate to @dcl/crypto-middleware 6 and harden the scene check

Coverage Stats

1375 of 2151 branches covered (63.92%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

170 existing lines in 16 files now uncovered.

3258 of 4344 relevant lines covered (75.0%)

41.79 hits per line