stacklok / toolhive / 32368107584

70%

Build Type

push

github

Committed by web-flow

Commit Message

Restore transport-port metrics behind a migration switch (#6370)

* Restore transport-port metrics behind a migration switch

#6296 moved /metrics to a diagnostics port. That is a breaking change for
any deployment scraping the old location, and it has not shipped yet, so
there is still room to give it a notice window rather than land it cold.

Serve /metrics on both ports for now. The diagnostics listener always
runs; the transport-port copy is controlled by MetricsOnTransportPort and
defaults to on, so no existing scrape configuration breaks. Operators can
move a scraper to the new port, verify it, and set the field to false to
prove nothing else depended on the old one. Closing the window is a
one-line change to DefaultMetricsOnTransportPort.

The field is a pointer with no kubebuilder default, which is what makes
the eventual flip work. RunConfig.TelemetryConfig is serialised and CRD
defaults are materialised at admission, so a plain bool would be written
into every workload created during the window and would survive the
cutover unchanged -- the flip would silently move nobody. Nil means unset
and is resolved at startup instead, with tests covering both the
resolution and the round trip.

Deployments that set the field explicitly are deliberately not moved by
the flip.

Part of #6271

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Point the deprecation notice at a tracking issue

The notice said the transport-port copy would be removed but never said
when, and a deprecation without a deadline is easy to ignore. Users also
had nowhere to look for the plan.

Reference #6384 from the startup warning, the field documentation, and the
migration steps. A tracking issue rather than a version or date: the
release that closes the window is not known yet and may move, and the
issue can be revised where these strings cannot -- the field description
ships to users through the CRD schema and kubectl explain.

Also point DefaultMetricsOn... (continued)

Coverage Stats

12 of 23 new or added lines in 4 files covered. (52.17%)

8 existing lines in 3 files now uncovered.

74302 of 107334 relevant lines covered (69.23%)

88.68 hits per line