supabase / supabase-swift / 32359048881

87%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(postgrest)!: make client and builders stateless value types (#1240)

* refactor(postgrest)!: make PostgrestClient and builders stateless value types

Replace the PostgrestBuilder/PostgrestQueryBuilder/PostgrestFilterBuilder/
PostgrestTransformBuilder class hierarchy with a single generic
PostgrestRequestBuilder<Phase> struct, using phantom-typed phases
(PostgrestQueryPhase/PostgrestFilterPhase/PostgrestTransformPhase) and
protocol-refinement-based conditional conformance
(PostgrestExecutablePhase/PostgrestTransformablePhase/PostgrestFilterablePhase)
to encode the builder phase graph at compile time. PostgrestClient becomes a
struct too, with setAuth(_:) replaced by a constructor-injected accessToken
closure resolved fresh per request, mirroring FunctionsClient/RealtimeClientV2.

* fix(postgrest): extract Operator to a top-level type shared across phases

A struct nested inside any extension of a generic type -- constrained or
not -- is a distinct type per generic specialization, so the previous
`extension PostgrestRequestBuilder { struct Operator { ... } }` produced
three unrelated Operator types (one per phase typealias) instead of one
shared type, and forced all 25 operator constants into computed
`static var`s. Extract Operator to a top-level PostgrestOperator type and
alias it back onto PostgrestRequestBuilder as `Operator`, restoring the
constants to real `static let`s.

* test(postgrest): cover accessToken resolution and phase-preservation

Adds coverage for the accessToken closure added in the PostgrestClient
statelessness refactor (resolution timing, explicit-header precedence,
error propagation) and a regression test locking in that maybeSingle()'s
isMaybeSingle flag survives a later transform call like order(...).

* fix(examples): remove unsafe PostgrestFilterBuilder downcast in FilteringView

query.order(...) as! PostgrestFilterBuilder relied on PostgrestFilterBuilder
and PostgrestTransformBuilder sharing a class instance under th... (continued)

Coverage Stats

511 of 529 new or added lines in 6 files covered. (96.6%)

3 existing lines in 1 file now uncovered.

9056 of 10397 relevant lines covered (87.1%)

165.63 hits per line