go-pkgz / pool / 32350287537

97%

master: 97%

Build Type

Pull #13

github

Committed by paskal

Commit Message

run pool completion after a worker error, not by chance

a failing worker cancels the errgroup context, so a surviving worker exits with
context.Canceled and suppresses poolCompleteFn, while the same worker exiting
through the drained channels reports nil and runs it. which one happens is up to
the scheduler, so a chained pool got its next stage closed about half the time.

decide the suppression on the context passed to Go, which only the caller can
cancel, instead of on lastErr.

Pull Request Pull Request #13: run pool completion after a worker error, not by chance

Coverage Stats

11 of 11 new or added lines in 1 file covered. (100.0%)

16 existing lines in 1 file now uncovered.

630 of 651 relevant lines covered (96.77%)

153485.5 hits per line