openconfig / featureprofiles / 32349791020

8%

push

github

CNTR: fix gNOI cache staleness after cold reboot and supervisor failover (#5509)

The CNTR-1.8 cold-reboot test and CNTR-3 supervisor-failover tests fail
on Arista EOS because containerz state verification happens after control
plane disruption. The DUT may reboot or switch supervisors while Ondatra
still holds cached pre-disruption gNOI clients, containerz configuration
may not be saved to startup-config, the standby supervisor may need extra
time to rejoin, and Docker/containerz may restart during recovery.

CNTR-1.8, cold-reboot persistence: save the running configuration before
reboot when the platform requires an explicit config save. After the DUT
comes back, skip the normal containerz config push and build the containerz
client from fresh gNOI clients so the test does not restart the management
stack during warmup or reuse a stale pre-reboot gNOI connection.

CNTR-1.8, reboot detection: add WaitForReboot to poll short-timeout
DialGNMI and system time reads until the DUT is reachable again, then
return fresh BindingDUT().DialGNOI clients. This avoids hanging on stale
half-open connections and handles the case where the reboot completed
before the verification subtest started polling.

CNTR-1, Arista deviations: enable containerz_require_explicit_config_save so
the cold-reboot persistence test saves startup-config before rebooting.

CNTR-3, switchover readiness: wait for the active supervisor's
switchover-ready leaf instead of the standby's leaf, and allow an
Arista-specific stabilization delay before declaring readiness failure.
The active supervisor reports whether the standby is ready to take over
more reliably than the standby's own state during standby mode.

CNTR-3, SwitchControlProcessor retry: use fresh gNOI clients when required
and retry SwitchControlProcessor on gRPC Unavailable while the DUT remains
reachable. Stop retrying once the device goes unreachable, because that
means the switchover is already executing and the recovery poller... (continued)

0 of 30 new or added lines in 3 files covered. (0.0%)

2305 of 28542 relevant lines covered (8.08%)

0.09 hits per line