IgniteUI / igniteui-webcomponents / 32342071225

98%

push

github

fix(radio): repair group membership, derived tab stops and group propagation (#2344)

The group of a radio was resolved by a tree walk over the whole root node on
every read, and the tab stop was patched on the radio that changed, so a group
could not react when a member left it. Removing or renaming the checked radio
stranded the radios that stayed on `tabindex="-1"`. Each radio now registers
under its root node and name for its whole life-cycle, and every mutation
derives the tab stop from the state of the full group.

- Removing the checked radio, or moving it to another group with `name`, hands
  the tab stop back to the radios that stay. This applies to plain name-based
  groups and not only to the ones under an `igc-radio-group`.
- A form reset derives the tab stop again, because the reset restores the
  default state without the `checked` setter.
- `igc-radio-group` adopts the radios that are slotted at run time - `name`,
  `defaultValue` and a pending `value` all apply to them - and reports the
  pending `value` while it holds no radios.
- The group reflects `alignment` as `aria-orientation`, keeps its `role`, and no
  longer reports an empty group as disabled.
- A group read is the size of the group instead of the size of the root node,
  and the four overlapping arrays of `getGroup` give way to one member query.
- The tab stop comes from the enabled checked radio, and each change of
  `disabled` derives it again.
- `igc-radio-group` keeps its value only while it is pending, so the removal of
  the checked radio no longer selects the radio of an old value.
- The `checked` setter derives the group state only when the selection changes.

7011 of 7356 branches covered (95.31%)

Branch coverage included in aggregate %.

321 of 323 new or added lines in 5 files covered. (99.38%)

48774 of 49359 relevant lines covered (98.81%)

1451.07 hits per line